deck: used fisher-yates algorithm to shuffle deck array #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethdivyansh
force-pushed
the
fix/issue-#2
branch
from
38a68d9 to
73a5f1c
Compare
Varun-Kolanu
force-pushed
the
master
branch
2 times, most recently
from
f828c52 to
a008630
Compare
sethdivyansh
force-pushed
the
fix/issue-#2
branch
from
73a5f1c to
5845678
Compare
kuv2707
reviewed
May 31, 2024
backend/uno-game-engine/deck.ts
Outdated
| @@ -66,5 +66,9 @@ function makeCard(type: CardType, color: CardColor, value: CardValue): UNOCard { | |||
| */ | |||
| function shuffle(deck: Array<any>) { | |||
| //todo: Implement a generic shuffling algorithm | |||
kuv2707
reviewed
May 31, 2024
backend/uno-game-engine/deck.ts
Outdated
| @@ -66,5 +66,9 @@ function makeCard(type: CardType, color: CardColor, value: CardValue): UNOCard { | |||
| */ | |||
| function shuffle(deck: Array<any>) { | |||
There was a problem hiding this comment.
any would cause eslint errors.
sethdivyansh
changed the title
sethdivyansh
force-pushed
the
fix/issue-#2
branch
from
5845678 to
98d809c
Compare
- added black as a color in `CardColor` in `types.d.ts` - separated the values of special cards and wild cards into two arrays named specialValues and wildCardValues, respectively. - Iterates over each color in the colors array. For each color: * Iterates over each number value (0 to 9) in the numValues array and adds two cards of that color for each number, except for '0' where only one card is added. * Iterates over each special value in the specialValues array and adds two cards of that color for each special value. * If the color is 'black', iterates over each wild card value in the wildCardValue array and adds four cards of that color for each wild card value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
used Fisher-Yates shuffle algorithm to shuffle the deck array.
Self-review checklist
Completed manual review and testing of the following: